Re: [PATCH 2/2] refs: loosen restriction on wildcard * refspecs

2015-07-23 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: On Wed, Jul 22, 2015 at 5:05 PM, Jacob Keller jacob.e.kel...@intel.com wrote: From: Jacob Keller jacob.kel...@gmail.com Modify logic of check_refname_component and add a new disposition regarding *. Allow refspecs that contain a single * if

Re: [PATCH 2/2] refs: loosen restriction on wildcard * refspecs

2015-07-23 Thread Keller, Jacob E
On Thu, 2015-07-23 at 15:12 -0700, Junio C Hamano wrote: Eric Sunshine sunsh...@sunshineco.com writes: On Wed, Jul 22, 2015 at 5:05 PM, Jacob Keller jacob.e.kel...@intel.com wrote: From: Jacob Keller jacob.kel...@gmail.com Modify logic of check_refname_component and add a new

Re: [PATCH 2/2] refs: loosen restriction on wildcard * refspecs

2015-07-23 Thread Junio C Hamano
Keller, Jacob E jacob.e.kel...@intel.com writes: s/hangled/handled/ ... Thanks; here is what I queued yesterday. Woah. I bow to your imperative commit message abilities. The new commit message is very nicely worded. Heh, imperative is secondary. I just wanted to straighten out the

Re: [PATCH 2/2] refs: loosen restriction on wildcard * refspecs

2015-07-23 Thread Eric Sunshine
On Wed, Jul 22, 2015 at 5:05 PM, Jacob Keller jacob.e.kel...@intel.com wrote: From: Jacob Keller jacob.kel...@gmail.com Modify logic of check_refname_component and add a new disposition regarding *. Allow refspecs that contain a single * if REFNAME_REFSPEC_PATTERN is set. Change the function

Re: [PATCH 2/2] refs: loosen restriction on wildcard * refspecs

2015-07-23 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Will squash the changes; no need to resend (unless people discover other issues; let's hope that I wouldn't be the one to do so ;-). Thanks. diff --git i/t/t5511-refspec.sh w/t/t5511-refspec.sh index de6db86ccff0..7bfca7962d41 100755 ---

Re: [PATCH 2/2] refs: loosen restriction on wildcard * refspecs

2015-07-23 Thread Jacob Keller
On Thu, Jul 23, 2015 at 10:13 AM, Junio C Hamano gits...@pobox.com wrote: That was whitespace damaged, so I had to hand-tweak the file in place. While at it, I noticed that we do not check a case where multiple asterisks appear in a single component (which is rejected for a reason different

Re: [PATCH 2/2] refs: loosen restriction on wildcard * refspecs

2015-07-23 Thread Jacob Keller
On Thu, Jul 23, 2015 at 9:44 AM, Junio C Hamano gits...@pobox.com wrote: Jacob Keller jacob.kel...@gmail.com writes: By the way, have you run test suite before sending this (or any previous round of this) patch? This seems to break t5511-refspec.sh for me. Looks like another location I

Re: [PATCH 2/2] refs: loosen restriction on wildcard * refspecs

2015-07-23 Thread Junio C Hamano
Jacob Keller jacob.kel...@gmail.com writes: By the way, have you run test suite before sending this (or any previous round of this) patch? This seems to break t5511-refspec.sh for me. Looks like another location I forgot to update. I can send a re-spin if you need with the following diff.

Re: [PATCH 2/2] refs: loosen restriction on wildcard * refspecs

2015-07-22 Thread Junio C Hamano
Jacob Keller jacob.e.kel...@intel.com writes: From: Jacob Keller jacob.kel...@gmail.com Modify logic of check_refname_component and add a new disposition regarding *. Allow refspecs that contain a single * if REFNAME_REFSPEC_PATTERN is set. Change the function to pass the flags as a

[PATCH 2/2] refs: loosen restriction on wildcard * refspecs

2015-07-22 Thread Jacob Keller
From: Jacob Keller jacob.kel...@gmail.com Modify logic of check_refname_component and add a new disposition regarding *. Allow refspecs that contain a single * if REFNAME_REFSPEC_PATTERN is set. Change the function to pass the flags as a pointer, and clear REFNAME_REFSPEC_PATTERN after the first

Re: [PATCH 2/2] refs: loosen restriction on wildcard * refspecs

2015-07-22 Thread Jacob Keller
On Wed, Jul 22, 2015 at 3:04 PM, Junio C Hamano gits...@pobox.com wrote: Jacob Keller jacob.e.kel...@intel.com writes: From: Jacob Keller jacob.kel...@gmail.com Modify logic of check_refname_component and add a new disposition regarding *. Allow refspecs that contain a single * if