Re: [PATCH 2/2] submodule-helper: fix indexing in clone retry error reporting path

On Fri, Jul 22, 2016 at 12:52 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> The approach to tests is different though. I like yours better than mine, >> as it doesn't add more tests, but strengthens existing tests. > > So... are you retracting >

Re: [PATCH 2/2] submodule-helper: fix indexing in clone retry error reporting path

Stefan Beller writes: >> I expect I'd queue these two instead, after seeing Acks from Stefan. >> >> Thanks. > > Sure. Please take these 2 patches instead of mine. OK, I've already queued yours but I haven't started today's integration cycle yet (I first pick up new topics

Re: [PATCH 2/2] submodule-helper: fix indexing in clone retry error reporting path

Stefan Beller writes: > The approach to tests is different though. I like yours better than mine, > as it doesn't add more tests, but strengthens existing tests. So... are you retracting http://thread.gmane.org/gmane.comp.version-control.git/25 and instead giving an Ack

Re: [PATCH 2/2] submodule-helper: fix indexing in clone retry error reporting path

On Fri, Jul 22, 2016 at 12:39 PM, Junio C Hamano wrote: > Johannes Sixt writes: > >> 'git submodule--helper update-clone' has logic to retry failed clones >> a second time. For this purpose, there is a list of submodules to clone, >> and a second list that is

Re: [PATCH 2/2] submodule-helper: fix indexing in clone retry error reporting path

Johannes Sixt writes: > 'git submodule--helper update-clone' has logic to retry failed clones > a second time. For this purpose, there is a list of submodules to clone, > and a second list that is filled with the submodules to retry. Within > these lists, the submodules are

Re: [PATCH 2/2] submodule-helper: fix indexing in clone retry error reporting path

On Fri, Jul 22, 2016 at 12:15 PM, Johannes Sixt wrote: > 'git submodule--helper update-clone' has logic to retry failed clones > a second time. For this purpose, there is a list of submodules to clone, > and a second list that is filled with the submodules to retry. Within > these

[PATCH 2/2] submodule-helper: fix indexing in clone retry error reporting path

'git submodule--helper update-clone' has logic to retry failed clones a second time. For this purpose, there is a list of submodules to clone, and a second list that is filled with the submodules to retry. Within these lists, the submodules are identified by an index as if both lists were just