Re: [PATCH 2/2] submodule.c: warn about missing submodule git directories

2018-09-07 Thread Jonathan Nieder
Hi, Stefan Beller wrote: > On Wed, Sep 5, 2018 at 12:18 PM Jonathan Nieder wrote: >> Stefan Beller wrote: >>> This is the continuation of f2d48994dc1 (submodule.c: submodule_move_head >>> works with broken submodules, 2017-04-18), which tones down the case of >>> "broken submodule" in case of a

Re: [PATCH 2/2] submodule.c: warn about missing submodule git directories

2018-09-07 Thread Stefan Beller
On Wed, Sep 5, 2018 at 12:18 PM Jonathan Nieder wrote: > > Hi, > > Stefan Beller wrote: > > > This is the continuation of f2d48994dc1 (submodule.c: submodule_move_head > > works with broken submodules, 2017-04-18), which tones down the case of > > "broken submodule" in case of a missing git

Re: [PATCH 2/2] submodule.c: warn about missing submodule git directories

2018-09-05 Thread Jonathan Nieder
Hi, Stefan Beller wrote: > This is the continuation of f2d48994dc1 (submodule.c: submodule_move_head > works with broken submodules, 2017-04-18), which tones down the case of > "broken submodule" in case of a missing git directory of the submodule to > be only a warning. > > Signed-off-by:

Re: [PATCH 2/2] submodule.c: warn about missing submodule git directories

2018-08-29 Thread Stefan Beller
On Wed, Aug 29, 2018 at 10:17 AM Junio C Hamano wrote: > > Stefan Beller writes: > > > Not quite, as this is ... > > > > Looking at the test in the previous patch, I would think a reasonable > > workflow > > in the test is ... > > > >> The MOVE_HEAD_FORCE codepath that follows this hunk is, eh,

Re: [PATCH 2/2] submodule.c: warn about missing submodule git directories

2018-08-29 Thread Junio C Hamano
Stefan Beller writes: > Not quite, as this is ... > > Looking at the test in the previous patch, I would think a reasonable workflow > in the test is ... > >> The MOVE_HEAD_FORCE codepath that follows this hunk is, eh, already >> forcing to correct the situation, so there is no need to touch

Re: [PATCH 2/2] submodule.c: warn about missing submodule git directories

2018-08-28 Thread Stefan Beller
On Tue, Aug 28, 2018 at 11:56 AM Junio C Hamano wrote: > > Stefan Beller writes: > > > This is the continuation of f2d48994dc1 (submodule.c: submodule_move_head > > works with broken submodules, 2017-04-18), which tones down the case of > > "broken submodule" in case of a missing git directory

Re: [PATCH 2/2] submodule.c: warn about missing submodule git directories

2018-08-28 Thread Junio C Hamano
Stefan Beller writes: > This is the continuation of f2d48994dc1 (submodule.c: submodule_move_head > works with broken submodules, 2017-04-18), which tones down the case of > "broken submodule" in case of a missing git directory of the submodule to > be only a warning. After seeing this warning,

[PATCH 2/2] submodule.c: warn about missing submodule git directories

2018-08-27 Thread Stefan Beller
This is the continuation of f2d48994dc1 (submodule.c: submodule_move_head works with broken submodules, 2017-04-18), which tones down the case of "broken submodule" in case of a missing git directory of the submodule to be only a warning. Signed-off-by: Stefan Beller --- submodule.c