Re: [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

Am 11.04.2017 um 01:23 schrieb Ævar Arnfjörð Bjarmason: > * Much of it fails due to GIT_CEILING_DIRECTORIES not working with > dirs with ":" in the name. Oh. That might hit me: I'm using URLs for parent directory names in a cache directory. urlencode may or may not work: >

Re: [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

On Tue, Apr 11, 2017 at 01:23:32AM +0200, Ævar Arnfjörð Bjarmason wrote: > * Most of the tests fail because git clone can't deal with cloning a > repo with a \r in the path. The error we produce when we try is quite > bad and doesn't indicate what went wrong: > > $ rm -rf /tmp/git.*; mkdir

Re: [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

On Sun, Apr 9, 2017 at 9:11 PM, Ævar Arnfjörð Bjarmason wrote: > Change the test library to insert non-alphanumeric ASCII characters > into the TRASH_DIRECTORY name, that's the directory the test library > creates, chdirs to and runs each individual test from. I did a bit more

Re: [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

On Mon, Apr 10, 2017 at 08:19:40PM +0200, Joachim Durchholz wrote: > > I very much disagree with that. Git's test operate under a set of > > assumptions, and if you violate those assumptions, then the failures are > > not meaningful. > > In that case the tests do not validate that git can

Re: [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

Am 10.04.2017 um 18:57 schrieb Jeff King: If there are security bugs where a malicious input can cause us to do something bad, that's something to care about. But that's very different than asking "do these tests run to completion with a funny input". If the tests do not complete, git is doing

Re: [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

On Mon, Apr 10, 2017 at 04:59:57PM +0200, Joachim Durchholz wrote: > Am 10.04.2017 um 15:38 schrieb Jeff King: > > Are those bugs? Maybe. Certainly they are limitations. But are they ones > > anybody _cares_ about? I think this may fall under "if it hurts, don't > > do it". > > It's not always

Re: [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

Am 10.04.2017 um 15:38 schrieb Jeff King: Are those bugs? Maybe. Certainly they are limitations. But are they ones anybody _cares_ about? I think this may fall under "if it hurts, don't do it". It's not always possible to avoid that. URLs, for example, may contain "funny characters",

Re: [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

On Mon, Apr 10, 2017 at 1:40 PM, Ævar Arnfjörð Bjarmason wrote: > On Mon, Apr 10, 2017 at 1:19 PM, SZEDER Gábor wrote: >> A few other failures are triggered by the ':' in the trash directory's >> name, breaking the following commonly used pattern: >> >>

Re: [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

On Mon, Apr 10, 2017 at 01:40:13PM +0200, Ævar Arnfjörð Bjarmason wrote: > > A few other failures are triggered by the ':' in the trash directory's > > name, breaking the following commonly used pattern: > > > > export GIT_CEILING_DIRECTORIES="$TRASH_DIRECTORY" && > > cd subdir && > >

Re: [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

On Mon, Apr 10, 2017 at 1:19 PM, SZEDER Gábor wrote: > On Mon, Apr 10, 2017 at 10:02 AM, Ævar Arnfjörð Bjarmason > wrote: >> On Mon, Apr 10, 2017 at 3:47 AM, SZEDER Gábor wrote: Change the test library to insert non-alphanumeric

Re: [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

On Mon, Apr 10, 2017 at 10:02 AM, Ævar Arnfjörð Bjarmason wrote: > On Mon, Apr 10, 2017 at 3:47 AM, SZEDER Gábor wrote: >>> Change the test library to insert non-alphanumeric ASCII characters >>> into the TRASH_DIRECTORY name, that's the directory the test

Re: [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

On Mon, Apr 10, 2017 at 3:47 AM, SZEDER Gábor wrote: >> Change the test library to insert non-alphanumeric ASCII characters >> into the TRASH_DIRECTORY name, that's the directory the test library >> creates, chdirs to and runs each individual test from. >> >> Unless

Re: [PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

> Change the test library to insert non-alphanumeric ASCII characters > into the TRASH_DIRECTORY name, that's the directory the test library > creates, chdirs to and runs each individual test from. > > Unless test_fails_on_unusual_directory_names=1 is declared before > importing test-lib.sh (and

[PATCH 2/2] test-lib: exhaustively insert non-alnum ASCII into the TRASH_DIRECTORY name

Change the test library to insert non-alphanumeric ASCII characters into the TRASH_DIRECTORY name, that's the directory the test library creates, chdirs to and runs each individual test from. Unless test_fails_on_unusual_directory_names=1 is declared before importing test-lib.sh (and if perl