Re: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule

2014-10-28 Thread Jeff King
On Mon, Oct 27, 2014 at 10:42:21AM -0700, Junio C Hamano wrote: > >> I believe I can work around the error with an "export _C89_CCMODE=1", > >> but I thought I'd send the patch since this is the only occurrence of > >> the problem, and the argument order is inconsistent with other linker > >> comm

Re: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule

2014-10-27 Thread Junio C Hamano
Jeff King writes: > On Sun, Oct 26, 2014 at 02:54:56PM -0400, David Michael wrote: > >> Yes, the compiler refuses to run by default when a "-L" option occurs >> after a source/object file. It tries to interpret it as another file >> name and fails. > > Yeah, I think I have seen similar behavior

Re: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule

2014-10-26 Thread Jeff King
On Sun, Oct 26, 2014 at 02:54:56PM -0400, David Michael wrote: > Yes, the compiler refuses to run by default when a "-L" option occurs > after a source/object file. It tries to interpret it as another file > name and fails. Yeah, I think I have seen similar behavior before, but it has been long

Re: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule

2014-10-26 Thread David Michael
On Sun, Oct 26, 2014 at 2:35 PM, Jeff King wrote: > On Sun, Oct 26, 2014 at 01:45:10PM -0400, Eric Sunshine wrote: > >> On Sun, Oct 26, 2014 at 1:33 PM, David Michael wrote: >> > The XL C compiler can fail due to mixing library path and object >> >> Can you explain in the commit message the actua

Re: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule

2014-10-26 Thread Jeff King
On Sun, Oct 26, 2014 at 01:45:10PM -0400, Eric Sunshine wrote: > On Sun, Oct 26, 2014 at 1:33 PM, David Michael wrote: > > The XL C compiler can fail due to mixing library path and object > > Can you explain in the commit message the actual nature of the failure > so that readers can understand

Re: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule

2014-10-26 Thread Eric Sunshine
On Sun, Oct 26, 2014 at 1:33 PM, David Michael wrote: > The XL C compiler can fail due to mixing library path and object Can you explain in the commit message the actual nature of the failure so that readers can understand more precisely how this change helps? > file arguments, for example when

[PATCH 2/3] Makefile: Reorder linker flags in the git executable rule

2014-10-26 Thread David Michael
The XL C compiler can fail due to mixing library path and object file arguments, for example when linking git while building with "gmake LDFLAGS=-L$prefix/lib". This moves the ALL_LDFLAGS variable expansion in the git executable rule to be consistent with all the other linking rules. Signed-off-b