Re: [PATCH 2/3] add basic lua infrastructure

2012-09-25 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Tue, Sep 25, 2012 at 03:21:10AM +, Robin H. Johnson wrote: On Mon, Sep 24, 2012 at 08:25:12PM -0400, Jeff King wrote: +ifdef USE_LUA + BASIC_CFLAGS += -DUSE_LUA `pkg-config --cflags lua5.2` + EXTLIBS += `pkg-config --libs lua5.2` +endif Can

[PATCH 2/3] add basic lua infrastructure

2012-09-24 Thread Jeff King
This adds a small module for examining parts of a commit from inside a lua interpreter. Eventually you'll be able to do grep-like filtering and --pretty formatting. The most naive presentation would be to parse the whole commit and put it in a lua table. However, instead we build upon the

Re: [PATCH 2/3] add basic lua infrastructure

2012-09-24 Thread Nguyen Thai Ngoc Duy
On Tue, Sep 25, 2012 at 7:25 AM, Jeff King p...@peff.net wrote: +ifdef USE_LUA + BASIC_CFLAGS += -DUSE_LUA `pkg-config --cflags lua5.2` + EXTLIBS += `pkg-config --libs lua5.2` +endif + I remember we paid noticeable penalty when linking with libcurl to main git binary and Linus

Re: [PATCH 2/3] add basic lua infrastructure

2012-09-24 Thread Robin H. Johnson
On Mon, Sep 24, 2012 at 08:25:12PM -0400, Jeff King wrote: +ifdef USE_LUA + BASIC_CFLAGS += -DUSE_LUA `pkg-config --cflags lua5.2` + EXTLIBS += `pkg-config --libs lua5.2` +endif Can you please hoist the packagename out to a variable? It's just plain lua on Gentoo. -- Robin Hugh

Re: [PATCH 2/3] add basic lua infrastructure

2012-09-24 Thread Jeff King
On Tue, Sep 25, 2012 at 08:55:23AM +0700, Nguyen Thai Ngoc Duy wrote: On Tue, Sep 25, 2012 at 7:25 AM, Jeff King p...@peff.net wrote: +ifdef USE_LUA + BASIC_CFLAGS += -DUSE_LUA `pkg-config --cflags lua5.2` + EXTLIBS += `pkg-config --libs lua5.2` +endif + I remember we