Jeff King writes:
> On Tue, Nov 06, 2018 at 04:48:28PM -0800, Carlo Arenas wrote:
>
> I think date_yesterday() is the only one of those special functions that
> gets called like this. Here's what I think we should do to fix it (this
> can go right on top of jk/misc-unused-fixes, which is already
On Tue, Nov 06, 2018 at 04:48:28PM -0800, Carlo Arenas wrote:
> On Thu, Nov 1, 2018 at 10:24 PM Jeff King wrote:
> >
> > static void date_yesterday(struct tm *tm, struct tm *now, int *num)
> > {
> > + *num = 0;
>
> the only caller (date_time) for this sends num = NULL, so this
>
On Thu, Nov 1, 2018 at 10:24 PM Jeff King wrote:
>
> static void date_yesterday(struct tm *tm, struct tm *now, int *num)
> {
> + *num = 0;
the only caller (date_time) for this sends num = NULL, so this
triggers a segfault.
the only reference I could find to that apparently unused
The approxidate parser has a table of special keywords like
"yesterday", "noon", "pm", etc. Some of these, like "pm", do
the right thing if we've recently seen a number: "3pm" is
what you'd think.
However, most of them do not look at or modify the
pending-number flag at all, which means a number
4 matches
Mail list logo
