Re: [PATCH 2/3] git-compat-util: define MIN through compat

2018-10-21 Thread Carlo Arenas
I agree with you; dropped

Re: [PATCH 2/3] git-compat-util: define MIN through compat

2018-10-21 Thread Junio C Hamano
Carlo Marcelo Arenas Belón writes: > this macro is commonly defined in system headers (usually ) > but if it is not define it here so it can be used elsewhere > > Signed-off-by: Carlo Marcelo Arenas Belón > --- I am between "meh" and "moderately negative" on this change. - Definition of MIN

[PATCH 2/3] git-compat-util: define MIN through compat

2018-10-21 Thread Carlo Marcelo Arenas Belón
this macro is commonly defined in system headers (usually ) but if it is not define it here so it can be used elsewhere Signed-off-by: Carlo Marcelo Arenas Belón --- git-compat-util.h | 5 + sha256/block/sha256.c | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/git