On Tue, Dec 18, 2012 at 01:28:47AM +0100, Sven Strickroth wrote: > If GIT_ASKPASS environment variable is not set, git-svn does not try to use > SSH_ASKPASS as git-core does. This change adds a fallback to SSH_ASKPASS. > > Signed-off-by: Sven Strickroth <em...@cs-ware.de> > ---
Thanks, this series looks fine to me. I skimmed through the original thread. It looks like we got bogged down in discussion of whether GIT_ASKPASS should fall back on error, and whether SSH_ASKPASS should come _after_ the terminal has been tried and failed. This version of the series brings the behavior of git-svn in line with the rest of git, which I think is a good first step. I don't know whether we want to take a second step and tweak the order in both perl and C code. Since nobody has mentioned it in the interim months, I'm assuming it's not a big deal, and people are happy enough with the current ordering. So unless somebody feels strongly about it, it's not worth bothering. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
