Re: [PATCH 2/3] receive-pack: verify push options in cert

2017-05-05 Thread Jonathan Nieder
Hi, Stefan Beller wrote: > On Fri, May 5, 2017 at 4:46 PM, Jonathan Tan wrote: >> This sets in stone the requirement that send-pack redundantly send its >> push options in 2 places, but I think that this is better than the >> alternatives. Sending push options only

Re: [PATCH 2/3] receive-pack: verify push options in cert

2017-05-05 Thread Jonathan Nieder
Hi, Jonathan Tan wrote: > In commit f6a4e61 ("push: accept push options", 2016-07-14), send-pack > was taught to include push options both within the signed cert (if the > push is a signed push) and outside the signed cert; however, > receive-pack ignores push options within the cert, only

Re: [PATCH 2/3] receive-pack: verify push options in cert

2017-05-05 Thread Brandon Williams
On 05/05, Stefan Beller wrote: > On Fri, May 5, 2017 at 4:46 PM, Jonathan Tan wrote: > > In commit f6a4e61 ("push: accept push options", 2016-07-14), send-pack > > was taught to include push options both within the signed cert (if the > > push is a signed push) and

Re: [PATCH 2/3] receive-pack: verify push options in cert

2017-05-05 Thread Stefan Beller
On Fri, May 5, 2017 at 4:46 PM, Jonathan Tan wrote: > In commit f6a4e61 ("push: accept push options", 2016-07-14), send-pack > was taught to include push options both within the signed cert (if the > push is a signed push) and outside the signed cert; however, >

[PATCH 2/3] receive-pack: verify push options in cert

2017-05-05 Thread Jonathan Tan
In commit f6a4e61 ("push: accept push options", 2016-07-14), send-pack was taught to include push options both within the signed cert (if the push is a signed push) and outside the signed cert; however, receive-pack ignores push options within the cert, only handling push options outside the cert.