Re: [PATCH 2/3] t1301: move movebits() to test-lib-functions.sh

2017-06-23 Thread Christian Couder
On Fri, Jun 23, 2017 at 1:09 AM, Ramsay Jones wrote: > > > On 22/06/17 20:52, Junio C Hamano wrote: >> Christian Couder writes: >> >>> As the movebits() function can be useful outside t1301, >>> let's move it into test-lib-functions.sh,

Re: [PATCH 2/3] t1301: move movebits() to test-lib-functions.sh

2017-06-22 Thread Junio C Hamano
Ramsay Jones writes: > On 22/06/17 20:52, Junio C Hamano wrote: >> Christian Couder writes: >> >>> As the movebits() function can be useful outside t1301, >>> let's move it into test-lib-functions.sh, and while at >>> it let's rename it

Re: [PATCH 2/3] t1301: move movebits() to test-lib-functions.sh

2017-06-22 Thread Ramsay Jones
On 22/06/17 20:52, Junio C Hamano wrote: > Christian Couder writes: > >> As the movebits() function can be useful outside t1301, >> let's move it into test-lib-functions.sh, and while at >> it let's rename it test_movebits(). > > Good thinking, especially on the

Re: [PATCH 2/3] t1301: move movebits() to test-lib-functions.sh

2017-06-22 Thread Junio C Hamano
Christian Couder writes: > As the movebits() function can be useful outside t1301, > let's move it into test-lib-functions.sh, and while at > it let's rename it test_movebits(). Good thinking, especially on the renaming.

[PATCH 2/3] t1301: move movebits() to test-lib-functions.sh

2017-06-22 Thread Christian Couder
As the movebits() function can be useful outside t1301, let's move it into test-lib-functions.sh, and while at it let's rename it test_movebits(). Signed-off-by: Christian Couder --- t/t1301-shared-repo.sh | 18 +++--- t/test-lib-functions.sh | 5 + 2