Re: [PATCH 2/5] test-lib: turn on ASan abort_on_error by default

2017-07-10 Thread Junio C Hamano
Jeff King writes: > By default, ASan will exit with code 1 when it sees an > error. This means we'll notice a problem when we expected > git to succeed, but not in a test_must_fail block. > > Let's ask it to actually raise SIGABRT instead. That will > give us a signal death that

[PATCH 2/5] test-lib: turn on ASan abort_on_error by default

2017-07-10 Thread Jeff King
By default, ASan will exit with code 1 when it sees an error. This means we'll notice a problem when we expected git to succeed, but not in a test_must_fail block. Let's ask it to actually raise SIGABRT instead. That will give us a signal death that test_must_fail will notice. As a bonus, it may