Re: [PATCH 2/5] travis-ci: use 'set -e' in the 32 bit Linux build job

2018-01-24 Thread Jeff King
On Wed, Jan 24, 2018 at 01:12:48PM +0100, SZEDER Gábor wrote: > >> -test -z $HOST_UID || (CI_USER="ci" && useradd -u $HOST_UID $CI_USER) && > [...] > Indeed, the && chain is broken, I didn't noticed that. > > Luckily it was broken in a way that it didn't lead to false successes: > if installing

Re: [PATCH 2/5] travis-ci: use 'set -e' in the 32 bit Linux build job

2018-01-24 Thread SZEDER Gábor
On Tue, Jan 23, 2018 at 5:26 PM, Jeff King wrote: > On Mon, Jan 22, 2018 at 02:32:17PM +0100, SZEDER Gábor wrote: > >> All 'ci/*' scripts use 'set -e' to break the build job if a command >> fails, except 'ci/run-linux32-build.sh' which relies on the && chain >> to do the same.

Re: [PATCH 2/5] travis-ci: use 'set -e' in the 32 bit Linux build job

2018-01-23 Thread Jeff King
On Tue, Jan 23, 2018 at 11:26:33AM -0500, Jeff King wrote: > > +HOST_UID=$1 > > +CI_USER=$USER > > +test -z $HOST_UID || (CI_USER="ci" && useradd -u $HOST_UID $CI_USER) > > If this "useradd" step fails, we wouldn't abort the script, because it's > part of a conditional. You'd need a manual "||

Re: [PATCH 2/5] travis-ci: use 'set -e' in the 32 bit Linux build job

2018-01-23 Thread Jeff King
On Mon, Jan 22, 2018 at 02:32:17PM +0100, SZEDER Gábor wrote: > All 'ci/*' scripts use 'set -e' to break the build job if a command > fails, except 'ci/run-linux32-build.sh' which relies on the && chain > to do the same. This inconsistency among the 'ci/*' scripts is asking > for trouble: I

[PATCH 2/5] travis-ci: use 'set -e' in the 32 bit Linux build job

2018-01-22 Thread SZEDER Gábor
All 'ci/*' scripts use 'set -e' to break the build job if a command fails, except 'ci/run-linux32-build.sh' which relies on the && chain to do the same. This inconsistency among the 'ci/*' scripts is asking for trouble: I forgot about the && chain more than once while working on this patch