[PATCH 2/9] t1508 (at-combinations): test branches separately

2013-05-02 Thread Ramkumar Ramachandra
From: Felipe Contreras felipe.contre...@gmail.com In the tests involving @{-1} and @{u} as the final component, what we really want to check is if it's pointing to the right ref. We currently check the tip commit of the ref, but we can clarify this by separating out checking for commits versus

Re: [PATCH 2/9] t1508 (at-combinations): test branches separately

2013-05-02 Thread Felipe Contreras
On Thu, May 2, 2013 at 8:39 AM, Ramkumar Ramachandra artag...@gmail.com wrote: From: Felipe Contreras felipe.contre...@gmail.com In the tests involving @{-1} and @{u} as the final component, what we really want to check is if it's pointing to the right ref. We currently check the tip commit

Re: [PATCH 2/9] t1508 (at-combinations): test branches separately

2013-05-02 Thread Ramkumar Ramachandra
Felipe Contreras wrote: I'm not sure about this. If we introduce a check that fails, we would have to do: check HEAD refs/heads/new-branch failure Which doesn't seem clean. Perhaps it makes more sense to always add the type of check: check HEAD ref refs/heads/new-branch I think you

Re: [PATCH 2/9] t1508 (at-combinations): test branches separately

2013-05-02 Thread Felipe Contreras
On Thu, May 2, 2013 at 12:28 PM, Ramkumar Ramachandra artag...@gmail.com wrote: Felipe Contreras wrote: I'm not sure about this. If we introduce a check that fails, we would have to do: check HEAD refs/heads/new-branch failure Which doesn't seem clean. Perhaps it makes more sense to always