Re: [PATCH 2/9] vscode: hard-code a couple defines

2018-07-30 Thread Johannes Schindelin
Hi Jonathan, On Mon, 23 Jul 2018, Jonathan Nieder wrote: > Johannes Schindelin via GitGitGadget wrote: > > > From: Johannes Schindelin > > > > Sadly, we do not get all of the definitions via ALL_CFLAGS. Some defines > > are passed to GCC *only* when compiling specific files, such as git.o. > >

Re: [PATCH 2/9] vscode: hard-code a couple defines

2018-07-23 Thread Jonathan Nieder
Hi, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > > Sadly, we do not get all of the definitions via ALL_CFLAGS. Some defines > are passed to GCC *only* when compiling specific files, such as git.o. > > Let's just hard-code them into the script for the time being.

[PATCH 2/9] vscode: hard-code a couple defines

2018-07-23 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin Sadly, we do not get all of the definitions via ALL_CFLAGS. Some defines are passed to GCC *only* when compiling specific files, such as git.o. Let's just hard-code them into the script for the time being. Signed-off-by: Johannes Schindelin ---