Re: [PATCH 22/67] entry.c: convert strcpy to xsnprintf

2015-09-15 Thread Ramsay Jones
On 15/09/15 16:40, Jeff King wrote: > This particular conversion is non-obvious, because nobody > has passed our function the length of the destination > buffer. However, the interface to checkout_entry specifies > that the buffer must be at least TEMPORARY_FILENAME_LENGTH > bytes long, so we

[PATCH 22/67] entry.c: convert strcpy to xsnprintf

2015-09-15 Thread Jeff King
This particular conversion is non-obvious, because nobody has passed our function the length of the destination buffer. However, the interface to checkout_entry specifies that the buffer must be at least TEMPORARY_FILENAME_LENGTH bytes long, so we can check that (meaning the existing code was not

Re: [PATCH 22/67] entry.c: convert strcpy to xsnprintf

2015-09-15 Thread Stefan Beller
On Tue, Sep 15, 2015 at 12:01 PM, Ramsay Jones wrote: > > > On 15/09/15 16:40, Jeff King wrote: >> This particular conversion is non-obvious, because nobody >> has passed our function the length of the destination >> buffer. However, the interface to checkout_entry