Re: [PATCH 3/3] Silence a bunch of format-zero-length warnings

2014-05-07 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Sun, May 04, 2014 at 07:01:22PM +, brian m. carlson wrote: On Sun, May 04, 2014 at 01:12:55AM -0500, Felipe Contreras wrote: This is in gcc 4.9.0: wt-status.c: In function ‘wt_status_print_unmerged_header’: wt-status.c:191:2: warning:

Re: Re: [PATCH 3/3] Silence a bunch of format-zero-length warnings

2014-05-07 Thread Heiko Voigt
On Wed, May 07, 2014 at 11:19:09AM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: On Sun, May 04, 2014 at 07:01:22PM +, brian m. carlson wrote: On Sun, May 04, 2014 at 01:12:55AM -0500, Felipe Contreras wrote: This is in gcc 4.9.0: wt-status.c: In function

Re: [PATCH 3/3] Silence a bunch of format-zero-length warnings

2014-05-07 Thread Junio C Hamano
Heiko Voigt hvo...@hvoigt.net writes: On Wed, May 07, 2014 at 11:19:09AM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: ... Yeah, this started last summer when we added __attribute__((format)) to the status_printf_ln calls, and I posted essentially the same patch. We kind

[PATCH 3/3] Silence a bunch of format-zero-length warnings

2014-05-04 Thread Felipe Contreras
This is in gcc 4.9.0: wt-status.c: In function ‘wt_status_print_unmerged_header’: wt-status.c:191:2: warning: zero-length gnu_printf format string [-Wformat-zero-length] status_printf_ln(s, c, ); ^ We could pass -Wno-format-zero-length, but it seems compiler-specific flags are

Re: [PATCH 3/3] Silence a bunch of format-zero-length warnings

2014-05-04 Thread brian m. carlson
On Sun, May 04, 2014 at 01:12:55AM -0500, Felipe Contreras wrote: This is in gcc 4.9.0: wt-status.c: In function ‘wt_status_print_unmerged_header’: wt-status.c:191:2: warning: zero-length gnu_printf format string [-Wformat-zero-length] status_printf_ln(s, c, ); ^ We could

Re: [PATCH 3/3] Silence a bunch of format-zero-length warnings

2014-05-04 Thread Felipe Contreras
brian m. carlson wrote: On Sun, May 04, 2014 at 01:12:55AM -0500, Felipe Contreras wrote: This is in gcc 4.9.0: wt-status.c: In function ‘wt_status_print_unmerged_header’: wt-status.c:191:2: warning: zero-length gnu_printf format string [-Wformat-zero-length]

Re: [PATCH 3/3] Silence a bunch of format-zero-length warnings

2014-05-04 Thread Jeff King
On Sun, May 04, 2014 at 07:01:22PM +, brian m. carlson wrote: On Sun, May 04, 2014 at 01:12:55AM -0500, Felipe Contreras wrote: This is in gcc 4.9.0: wt-status.c: In function ‘wt_status_print_unmerged_header’: wt-status.c:191:2: warning: zero-length gnu_printf format string