Re: [PATCH 3/3] blame,shortlog: don't make local option variables static

On Tue, Jun 14, 2016 at 12:32:15AM -0400, Eric Sunshine wrote: > > + struct string_list range_list = STRING_LIST_INIT_NODUP; > > Related to this series, there's an additional "fix" which ought to be > made, probably as a separate patch. In particular, in cmd_blame(): > > if (lno &&

Re: [PATCH 3/3] blame,shortlog: don't make local option variables static

On Mon, Jun 13, 2016 at 1:39 AM, Jeff King wrote: > There's no need for these option variables to be static, > except that they are referenced by the options array itself, > which is static. But having all of this static is simply > unnecessary and confusing (and inconsistent with

[PATCH 3/3] blame,shortlog: don't make local option variables static

There's no need for these option variables to be static, except that they are referenced by the options array itself, which is static. But having all of this static is simply unnecessary and confusing (and inconsistent with most other commands, which either use a static global option list or a