[PATCH 3/3] cache-tree: Write index with updated cache-tree after commit

2014-07-01 Thread David Turner
During the commit process, the cache-tree is updated. We need to write this updated cache-tree so that it's ready for subsequent commands. Add test code which demonstrates that git commit now writes the cache tree. Also demonstrate that cache-tree invalidation is correct. Signed-off-by: David

Re: [PATCH 3/3] cache-tree: Write index with updated cache-tree after commit

2014-07-01 Thread Junio C Hamano
David Turner dtur...@twopensource.com writes: During the commit process, the cache-tree is updated. We need to write this updated cache-tree so that it's ready for subsequent commands. Add test code which demonstrates that git commit now writes the cache tree. Also demonstrate that

Re: [PATCH 3/3] cache-tree: Write index with updated cache-tree after commit

2014-07-01 Thread David Turner
On Tue, 2014-07-01 at 15:45 -0700, Junio C Hamano wrote: I didn't notice it when I gave the previous review comment but while reviewing this round, we already do the cache-tree population for commit -a in this function, which suggests me that it is the right place to do these changes. Modulo

Re: [PATCH 3/3] cache-tree: Write index with updated cache-tree after commit

2014-06-30 Thread Junio C Hamano
David Turner dtur...@twopensource.com writes: During the commit process, the cache-tree is updated. We need to write this updated cache-tree so that it's ready for subsequent commands. Add test code which demonstrates that git commit now writes the cache tree. Also demonstrate that

[PATCH 3/3] cache-tree: Write index with updated cache-tree after commit

2014-06-30 Thread David Turner
During the commit process, the cache-tree is updated. We need to write this updated cache-tree so that it's ready for subsequent commands. Add test code which demonstrates that git commit now writes the cache tree. Also demonstrate that cache-tree invalidation is correct. Signed-off-by: David

Re: [PATCH 3/3] cache-tree: Write index with updated cache-tree after commit

2014-06-30 Thread Torsten Bögershausen
[] diff --git a/t/t0090-cache-tree.sh b/t/t0090-cache-tree.sh index 5383258..d50acb8 100755 --- a/t/t0090-cache-tree.sh +++ b/t/t0090-cache-tree.sh @@ -16,8 +16,31 @@ cmp_cache_tree () { # We don't bother with actually checking the SHA1: # test-dump-cache-tree already verifies that all

Re: [PATCH 3/3] cache-tree: Write index with updated cache-tree after commit

2014-06-30 Thread Johannes Sixt
Am 7/1/2014 6:26, schrieb Torsten Bögershausen: And as test -n tests for a non-zero string, could we write like this (and drop the local ?)? if test -n $1 then dir=$1/ else dir= fi These six lines can be written as dir=$1${1:+/} and 'local'

[PATCH 3/3] cache-tree: Write index with updated cache-tree after commit

2014-06-27 Thread David Turner
During the commit process, the cache-tree is updated. We need to write this updated cache-tree so that it's ready for subsequent commands. Add test code which demonstrates that git commit now writes the cache tree. Also demonstrate that cache-tree invalidation is correct. Signed-off-by: David