Re: [PATCH 3/3] clean: improve performance when removing lots of directories

2015-04-08 Thread Eric Sunshine
On Tue, Apr 7, 2015 at 3:55 PM, erik elfström erik.elfst...@gmail.com wrote: On Tue, Apr 7, 2015 at 12:10 AM, Eric Sunshine sunsh...@sunshineco.com wrote: On Mon, Apr 6, 2015 at 7:48 AM, Erik Elfström erik.elfst...@gmail.com wrote: diff --git a/builtin/clean.c b/builtin/clean.c index

Re: [PATCH 3/3] clean: improve performance when removing lots of directories

2015-04-07 Thread erik elfström
On Tue, Apr 7, 2015 at 12:10 AM, Eric Sunshine sunsh...@sunshineco.com wrote: On Mon, Apr 6, 2015 at 7:48 AM, Erik Elfström erik.elfst...@gmail.com wrote: Before this change, clean used resolve_gitlink_ref to check for the presence of nested git repositories. This had the drawback of creating

Re: [PATCH 3/3] clean: improve performance when removing lots of directories

2015-04-06 Thread Eric Sunshine
On Mon, Apr 6, 2015 at 7:48 AM, Erik Elfström erik.elfst...@gmail.com wrote: Before this change, clean used resolve_gitlink_ref to check for the presence of nested git repositories. This had the drawback of creating a ref_cache entry for every directory that should potentially be cleaned. The

[PATCH 3/3] clean: improve performance when removing lots of directories

2015-04-06 Thread Erik Elfström
Before this change, clean used resolve_gitlink_ref to check for the presence of nested git repositories. This had the drawback of creating a ref_cache entry for every directory that should potentially be cleaned. The linear search through the ref_cache list caused a massive performance hit for