Jeff King writes:
> On Wed, Jul 18, 2018 at 11:19:01AM -0700, Junio C Hamano wrote:
>
>> > It's also still inconsistent in the daemonize case. The run that yields
>> > the error won't return a non-zero exit. But the next run will exit with
>> > "2".
>>
>> I do not see this particular "inconsiste
On Wed, Jul 18, 2018 at 11:19:01AM -0700, Junio C Hamano wrote:
> > It's also still inconsistent in the daemonize case. The run that yields
> > the error won't return a non-zero exit. But the next run will exit with
> > "2".
>
> I do not see this particular "inconsistency" a problem. The run
> t
Jeff King writes:
>> Perhaps we should exit with 2 (not 0) in that "previous error" case
>> by default, and then have a configuration knob to turn that 2 into 0
>> for those who cannot easily modify the calling script? That way, we
>> by default will *not* break those who have been paying attent
On Wed, Jul 18, 2018 at 09:21:18AM -0700, Junio C Hamano wrote:
> > I still think that "repo" should probably stop respecting the exit code.
> > But that's no excuse for Git not to have a sensible exit code in the
> > first place.
>
> I am not yet convinced that this last step to exit with 0 is a
Jeff King writes:
>> There's nothing for the calling program to act on on the basis of that
>> error. Use status 0 consistently instead, to indicate that we decided
>> not to run a gc (just like if no housekeeping was required). This
>> way, repo and similar tools can get the benefit of the sam
On Mon, Jul 16, 2018 at 11:57:40PM -0700, Jonathan Nieder wrote:
> External tools like repo[1], though, do care about the exit status
> from "git gc --auto". In non-daemonized mode, the exit status is
> straightforward: if there is an error, it is nonzero, but after a
> warning like the above, th
Some build machines started consistently failing to fetch updated
source using "repo sync", with error
error: The last gc run reported the following. Please correct the root cause
and remove /build/.repo/projects/tools/git.git/gc.log.
Automatic cleanup will not be performed until the file is
7 matches
Mail list logo