Re: [PATCH 3/3] index-helper: take extra care with readlink

2016-04-11 Thread David Turner
On Mon, 2016-04-11 at 00:03 +0100, Ramsay Jones wrote: > It took me a few minutes to convince myself that, if index-helper is > the only writer for the symlink, that the call to readlink would > result in a properly NULL terminated string. This relies on the > initialization of the address variable

Re: [PATCH 3/3] index-helper: take extra care with readlink

2016-04-10 Thread Torsten Bögershausen
On 04/11/2016 01:03 AM, Ramsay Jones wrote: It took me a few minutes to convince myself that, if index-helper is the only writer for the symlink, that the call to readlink would result in a properly NULL terminated string. This relies on the Minor nit: s/NULL/NUL/ -- To unsubscribe from this l

[PATCH 3/3] index-helper: take extra care with readlink

2016-04-10 Thread Ramsay Jones
It took me a few minutes to convince myself that, if index-helper is the only writer for the symlink, that the call to readlink would result in a properly NULL terminated string. This relies on the initialization of the address variable setting each byte of the 'struct sockaddr_un' to zero and the