Re: [PATCH 3/3] submodule--helper: add intern-git-dir function

2016-11-22 Thread Junio C Hamano
Stefan Beller writes: > On Mon, Nov 21, 2016 at 11:07 PM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> So I guess we should test a bit more extensively, maybe >>> >>> git status >expect >>> git submodule embedgitdirs

Re: [PATCH 3/3] submodule--helper: add intern-git-dir function

2016-11-22 Thread Stefan Beller
On Mon, Nov 21, 2016 at 11:07 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> So I guess we should test a bit more extensively, maybe >> >> git status >expect >> git submodule embedgitdirs >> git status >actual >> test_cmp expect

Re: [PATCH 3/3] submodule--helper: add intern-git-dir function

2016-11-21 Thread Junio C Hamano
Stefan Beller writes: > So I guess we should test a bit more extensively, maybe > > git status >expect > git submodule embedgitdirs > git status >actual > test_cmp expect actual > # further testing via > test -f .. > test -d .. Something along

Re: [PATCH 3/3] submodule--helper: add intern-git-dir function

2016-11-21 Thread Stefan Beller
On Mon, Nov 21, 2016 at 1:14 PM, Junio C Hamano wrote: > > Does this format correctly? > > I somehow thought that second and subsequent paragraphs continued > with "+" want no indentation before them. See for example the > Values section in config.txt and see how entries for

Re: [PATCH 3/3] submodule--helper: add intern-git-dir function

2016-11-21 Thread Brandon Williams
On 11/21, Stefan Beller wrote: > diff --git a/t/t7412-submodule-interngitdirs.sh > b/t/t7412-submodule-interngitdirs.sh > new file mode 100755 > index 00..8938a4c8b7 > --- /dev/null > +++ b/t/t7412-submodule-interngitdirs.sh > @@ -0,0 +1,41 @@ > +#!/bin/sh > + > +test_description='Test

Re: [PATCH 3/3] submodule--helper: add intern-git-dir function

2016-11-21 Thread Junio C Hamano
Stefan Beller writes: > +interngitdirs:: > + Move the git directory of submodules into its superprojects > + `$GIT_DIR/modules` path and then connect the git directory and > + its working directory by setting the `core.worktree` and adding > + a .git file

[PATCH 3/3] submodule--helper: add intern-git-dir function

2016-11-21 Thread Stefan Beller
When a submodule has its git dir inside the working dir, the submodule support for checkout that we plan to add in a later patch will fail. Add functionality to migrate the git directory to be embedded into the superprojects git directory. Signed-off-by: Stefan Beller ---