Re: [PATCH 3/3] wt-status.c: Set the commitable flag in the collect phase.

2018-08-31 Thread Stephen & Linda Smith
On Friday, August 31, 2018 9:54:50 AM MST Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Leave the setting of the commitable flag in show_merge_in_progress. If > >> a check for merged commits is moved to the collect phase then other > >> --dry-run tests fail. > > "Some tests fail" i

Re: [PATCH 3/3] wt-status.c: Set the commitable flag in the collect phase.

2018-08-31 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Fri, Aug 31 2018, Stephen P. Smith wrote: > >> In an update to fix a bug with "commit --dry-run" it was found that >> the commitable flag was broken. The update was, at the time, >> accepted as it was better than the previous version. > > What update is this?

Re: [PATCH 3/3] wt-status.c: Set the commitable flag in the collect phase.

2018-08-31 Thread Ævar Arnfjörð Bjarmason
On Fri, Aug 31 2018, Stephen P. Smith wrote: > In an update to fix a bug with "commit --dry-run" it was found that > the commitable flag was broken. The update was, at the time, > accepted as it was better than the previous version. What update is this? I.e. git.git commit id? See the "or this

[PATCH 3/3] wt-status.c: Set the commitable flag in the collect phase.

2018-08-30 Thread Stephen P. Smith
In an update to fix a bug with "commit --dry-run" it was found that the commitable flag was broken. The update was, at the time, accepted as it was better than the previous version. Since the set of the flag had been done in wt_longstatus_print_updated, set the flag in wt_status_collect_updated_c