Michal Nazarewicz writes:
> Subject: [PATCH 3/4] Git.pm: Add interface for git credential command.
Ah, just a nitpick: usually we write the message without capital after
":" and without the final ".".
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe f
Michal Nazarewicz writes:
> From: Michal Nazarewicz
>
> Add a credential() function which is an interface to the
> git credential command.
Nice.
I think you should credit git-remote-mediawiki for the code in the
commit message. Perhaps have a first "copy/paste" commit, and then an
"adaptation"
On Wed, Feb 06, 2013 at 09:47:05PM +0100, Michal Nazarewicz wrote:
> +sub _credential_read {
> + my %credential;
> + my ($reader, $op) = (@_);
> + while (<$reader>) {
> + chomp;
> + my ($key, $value) = /([^=]*)=(.*)/;
Empty keys are not valid. Can we make this:
From: Michal Nazarewicz
Add a credential() function which is an interface to the
git credential command.
Signed-off-by: Michal Nazarewicz
---
perl/Git.pm | 112 +++-
1 file changed, 111 insertions(+), 1 deletion(-)
diff --git a/perl/Git.
4 matches
Mail list logo
