Re: [PATCH 3/4] argv_array: add argv_array_copy

2015-08-06 Thread Jeff King
On Thu, Aug 06, 2015 at 02:18:26PM -0400, Eric Sunshine wrote: > However, that begs the question: Why do you need argv_array_copy() at > all? Isn't the same functionality already provided by > argv_array_pushv()? To wit, a caller which wants to copy from 'src' to > 'dst' can already do: > > s

Re: [PATCH 3/4] argv_array: add argv_array_copy

2015-08-06 Thread Eric Sunshine
On Thu, Aug 6, 2015 at 1:35 PM, Stefan Beller wrote: > The copied argv array shall be an identical deep copy except for > the internal allocation value. > > Signed-off-by: Stefan Beller > --- > diff --git a/argv-array.c b/argv-array.c > index 256741d..6d9c1dd 100644 > --- a/argv-array.c > +++ b/a

[PATCH 3/4] argv_array: add argv_array_copy

2015-08-06 Thread Stefan Beller
The copied argv array shall be an identical deep copy except for the internal allocation value. CC: Jeff King Signed-off-by: Stefan Beller --- argv-array.c | 13 + argv-array.h | 1 + 2 files changed, 14 insertions(+) diff --git a/argv-array.c b/argv-array.c index 256741d..6d9c1dd