Re: [PATCH 3/4] t0021: use $PERL_PATH for rot13-filter.pl

2016-11-06 Thread Jeff King
On Sun, Nov 06, 2016 at 03:52:00PM +0100, Lars Schneider wrote: > Would it make sense to rename "rot13-filter.pl" to > "rot13-filter.pl.template" or something because of the > missing shebang? I think it makes sense to keep it as ".pl". Without the "#!" things like editors will use the

Re: [PATCH 3/4] t0021: use $PERL_PATH for rot13-filter.pl

2016-11-06 Thread Lars Schneider
> On 02 Nov 2016, at 19:20, Jeff King wrote: > > The rot13-filter.pl script hardcodes "#!/usr/bin/perl", and > does not respect $PERL_PATH at all. That is a problem if the > system does not have perl at that path, or if it has a perl > that is too old to run a complicated script

[PATCH 3/4] t0021: use $PERL_PATH for rot13-filter.pl

2016-11-02 Thread Jeff King
The rot13-filter.pl script hardcodes "#!/usr/bin/perl", and does not respect $PERL_PATH at all. That is a problem if the system does not have perl at that path, or if it has a perl that is too old to run a complicated script like the rot13-filter (but PERL_PATH points to a more modern one). We