Re: [PATCH 3/5] grep: fix bug when recuring with relative pathspec

2017-03-02 Thread Brandon Williams
On 02/28, Junio C Hamano wrote: > Brandon Williams writes: > > > /* Add super prefix */ > > + quote_path_relative(name, opt->prefix, ); > > Hmph, do you want a quoted version here, not just relative_path()? > > Perhaps add a test with an "unusual" byte (e.g. a

Re: [PATCH 3/5] grep: fix bug when recuring with relative pathspec

2017-02-28 Thread Junio C Hamano
Brandon Williams writes: > /* Add super prefix */ > + quote_path_relative(name, opt->prefix, ); Hmph, do you want a quoted version here, not just relative_path()? Perhaps add a test with an "unusual" byte (e.g. a double-quote) in the path? >

[PATCH 3/5] grep: fix bug when recuring with relative pathspec

2017-02-24 Thread Brandon Williams
Fix a bug which causes a child process for a submodule to error out when a relative pathspec with a ".." is provided in the superproject. While at it, correctly construct the super-prefix to be used in a submodule when not at the root of the repository. Signed-off-by: Brandon Williams