Re: [PATCH 3/5] rebase -i: add exec commands via the rebase--helper

Hi Liam, On Tue, 28 Nov 2017, liam Beguin wrote: > I just realized we could maybe add exec instructions only after pick > commands if we do add-exec-commands before rearrange-squash. That won't work, because the squash/fixup commands are pick commands before rearrange-squash. So you'd add one

Re: [PATCH 3/5] rebase -i: add exec commands via the rebase--helper

Hi Johannes, Thanks for taking the time to review this. On 27/11/17 05:42 PM, Johannes Schindelin wrote: > Hi Liam, > > could I ask for a favor? I'd like the oneline to start with > > rebase -i -x: ... > > (this would help future me to realize what this commit touches already > from the

Re: [PATCH 3/5] rebase -i: add exec commands via the rebase--helper

Hi Junio, On 27/11/17 12:14 AM, Junio C Hamano wrote: > Liam Beguin writes: > >> diff --git a/sequencer.c b/sequencer.c >> index fa94ed652d2c..810b7850748e 100644 >> --- a/sequencer.c >> +++ b/sequencer.c >> @@ -2492,6 +2492,52 @@ int sequencer_make_script(int keep_empty,

Re: [PATCH 3/5] rebase -i: add exec commands via the rebase--helper

Johannes Schindelin writes: > could I ask for a favor? I'd like the oneline to start with > > rebase -i -x: ... > > (this would help future me to realize what this commit touches already > from the concise graph output I favor). Excellent. >> Recent work on

Re: [PATCH 3/5] rebase -i: add exec commands via the rebase--helper

Johannes Schindelin writes: >> As the name of a public function, it does not feel that this hints >> it strongly enough that it is from and a part of sequencer.c API. > > How about a "yes, and" instead? As in: > > To further improve this patch, let's use the name >

Re: [PATCH 3/5] rebase -i: add exec commands via the rebase--helper

Hi Liam, could I ask for a favor? I'd like the oneline to start with rebase -i -x: ... (this would help future me to realize what this commit touches already from the concise graph output I favor). On Sun, 26 Nov 2017, Liam Beguin wrote: > Recent work on `git-rebase--interactive` aim

Re: [PATCH 3/5] rebase -i: add exec commands via the rebase--helper

Hi Junio, On Mon, 27 Nov 2017, Junio C Hamano wrote: > Liam Beguin writes: > > > diff --git a/sequencer.c b/sequencer.c > > index fa94ed652d2c..810b7850748e 100644 > > --- a/sequencer.c > > +++ b/sequencer.c > > @@ -2492,6 +2492,52 @@ int sequencer_make_script(int

Re: [PATCH 3/5] rebase -i: add exec commands via the rebase--helper

Liam Beguin writes: > diff --git a/sequencer.c b/sequencer.c > index fa94ed652d2c..810b7850748e 100644 > --- a/sequencer.c > +++ b/sequencer.c > @@ -2492,6 +2492,52 @@ int sequencer_make_script(int keep_empty, FILE *out, > return 0; > } > > +int

[PATCH 3/5] rebase -i: add exec commands via the rebase--helper

Recent work on `git-rebase--interactive` aim to convert shell code to C. Even if this is most likely not a big performance enhacement, let's convert it too since a comming change to abbreviate command names requires it to be updated. Signed-off-by: Liam Beguin ---