Re: [PATCH 3/5] submodule: export sanitized GIT_CONFIG_PARAMETERS

2016-04-28 Thread Johannes Schindelin
Hi, On Thu, 28 Apr 2016, Jeff King wrote: > On Thu, Apr 28, 2016 at 08:25:29AM -0700, Stefan Beller wrote: > > > > +test_expect_success 'cmdline credential config passes submodule update' ' > > > + # advance the submodule HEAD so that a fetch is required > > > + git commit

Re: [PATCH 3/5] submodule: export sanitized GIT_CONFIG_PARAMETERS

2016-04-28 Thread Jacob Keller
On Thu, Apr 28, 2016 at 8:36 AM, Jeff King wrote: > On Thu, Apr 28, 2016 at 08:28:29AM -0700, Jacob Keller wrote: > >> > diff --git a/git-submodule.sh b/git-submodule.sh >> > index 2a84d7e..3a40d4b 100755 >> > --- a/git-submodule.sh >> > +++ b/git-submodule.sh >> > @@ -200,6 +200,7

Re: [PATCH 3/5] submodule: export sanitized GIT_CONFIG_PARAMETERS

2016-04-28 Thread Stefan Beller
On Thu, Apr 28, 2016 at 8:28 AM, Jeff King wrote: > On Thu, Apr 28, 2016 at 08:25:29AM -0700, Stefan Beller wrote: > >> > +test_expect_success 'cmdline credential config passes submodule update' ' >> > + # advance the submodule HEAD so that a fetch is required >> > +

Re: [PATCH 3/5] submodule: export sanitized GIT_CONFIG_PARAMETERS

2016-04-28 Thread Jeff King
On Thu, Apr 28, 2016 at 08:25:29AM -0700, Stefan Beller wrote: > > +test_expect_success 'cmdline credential config passes submodule update' ' > > + # advance the submodule HEAD so that a fetch is required > > + git commit --allow-empty -m foo && > > + git push

Re: [PATCH 3/5] submodule: export sanitized GIT_CONFIG_PARAMETERS

2016-04-28 Thread Jacob Keller
On Thu, Apr 28, 2016 at 6:37 AM, Jeff King wrote: > Commit 14111fc (git: submodule honor -c credential.* from > command line, 2016-02-29) taught git-submodule.sh to save > the sanitized value of $GIT_CONFIG_PARAMETERS when clearing > the environment for a submodule. However, it

Re: [PATCH 3/5] submodule: export sanitized GIT_CONFIG_PARAMETERS

2016-04-28 Thread Stefan Beller
On Thu, Apr 28, 2016 at 6:37 AM, Jeff King wrote: > Commit 14111fc (git: submodule honor -c credential.* from > command line, 2016-02-29) taught git-submodule.sh to save > the sanitized value of $GIT_CONFIG_PARAMETERS when clearing > the environment for a submodule. However, it

[PATCH 3/5] submodule: export sanitized GIT_CONFIG_PARAMETERS

2016-04-28 Thread Jeff King
Commit 14111fc (git: submodule honor -c credential.* from command line, 2016-02-29) taught git-submodule.sh to save the sanitized value of $GIT_CONFIG_PARAMETERS when clearing the environment for a submodule. However, it failed to export the result, meaning that it had no effect for any