This is easier to read and avoids magic offset constants
which need to be in sync with the section-name we provide.
Signed-off-by: Jeff King p...@peff.net
---
convert.c | 6 +-
ll-merge.c | 6 +-
userdiff.c | 13 +++--
3 files changed, 5 insertions(+), 20 deletions(-)
diff
Jeff King wrote:
--- a/convert.c
+++ b/convert.c
@@ -465,10 +465,8 @@ static int read_convert_config(const char *var, const
char *value, void *cb)
* External conversion drivers are configured using
* filter.name.variable.
*/
- if (prefixcmp(var, filter.) || (ep =
On Mon, Jan 14, 2013 at 08:55:28AM -0800, Jonathan Nieder wrote:
Jeff King wrote:
--- a/convert.c
+++ b/convert.c
@@ -465,10 +465,8 @@ static int read_convert_config(const char *var, const
char *value, void *cb)
* External conversion drivers are configured using
*
On Mon, Jan 14, 2013 at 09:06:10AM -0800, Jeff King wrote:
struct config_key k;
parse_config_key(k, var);
if (strcmp(k.section, filter) || k.subsection))
return 0;
would be a better start (or having git_config do the first two lines
itself before triggering the callback).
4 matches
Mail list logo