Re: [PATCH 3/7] submodule: is_submodule_active to differentiate between new and old mode

2018-08-21 Thread Junio C Hamano
Stefan Beller writes: >> So I think this patch is insufficient, and needs to at least change >> the "submodule.active" codepath to return !!ret; otherwise, a caller >> that now expects 0 (not active), 1 (active but can lose URL) and 2 >> (active and the presence of URL makes it so) will be

Re: [PATCH 3/7] submodule: is_submodule_active to differentiate between new and old mode

2018-08-20 Thread Stefan Beller
On Thu, Aug 16, 2018 at 10:37 AM Junio C Hamano wrote: > > Stefan Beller writes: > > > The change a086f921a72 (submodule: decouple url and submodule interest, > > 2017-03-17) enables us to do more than originally thought. > > As the url setting was used both to actually set the url where to > >

Re: [PATCH 3/7] submodule: is_submodule_active to differentiate between new and old mode

2018-08-16 Thread Junio C Hamano
Stefan Beller writes: > The change a086f921a72 (submodule: decouple url and submodule interest, > 2017-03-17) enables us to do more than originally thought. > As the url setting was used both to actually set the url where to > obtain the submodule from, as well as used as a boolean flag later >

[PATCH 3/7] submodule: is_submodule_active to differentiate between new and old mode

2018-08-15 Thread Stefan Beller
The change a086f921a72 (submodule: decouple url and submodule interest, 2017-03-17) enables us to do more than originally thought. As the url setting was used both to actually set the url where to obtain the submodule from, as well as used as a boolean flag later to see if it was active, we would