Re: [PATCH 3/8] lock_ref_sha1_basic(): do not set force_write for missing references

2015-02-12 Thread Michael Haggerty
On 02/11/2015 01:05 AM, Jeff King wrote: > On Tue, Feb 10, 2015 at 03:24:47PM -0800, Stefan Beller wrote: > >> On Mon, Feb 9, 2015 at 1:12 AM, Michael Haggerty >> wrote: >>> If a reference is missing, its SHA-1 will be null_sha1, which can't >>> possibly match a new value that ref_transaction_co

Re: [PATCH 3/8] lock_ref_sha1_basic(): do not set force_write for missing references

2015-02-10 Thread Stefan Beller
On Tue, Feb 10, 2015 at 4:05 PM, Jeff King wrote: > On Tue, Feb 10, 2015 at 03:24:47PM -0800, Stefan Beller wrote: > >> On Mon, Feb 9, 2015 at 1:12 AM, Michael Haggerty >> wrote: >> > If a reference is missing, its SHA-1 will be null_sha1, which can't >> > possibly match a new value that ref_tra

Re: [PATCH 3/8] lock_ref_sha1_basic(): do not set force_write for missing references

2015-02-10 Thread Jeff King
On Tue, Feb 10, 2015 at 03:24:47PM -0800, Stefan Beller wrote: > On Mon, Feb 9, 2015 at 1:12 AM, Michael Haggerty wrote: > > If a reference is missing, its SHA-1 will be null_sha1, which can't > > possibly match a new value that ref_transaction_commit() is trying to > > update it to. So there is

Re: [PATCH 3/8] lock_ref_sha1_basic(): do not set force_write for missing references

2015-02-10 Thread Stefan Beller
On Mon, Feb 9, 2015 at 1:12 AM, Michael Haggerty wrote: > If a reference is missing, its SHA-1 will be null_sha1, which can't > possibly match a new value that ref_transaction_commit() is trying to > update it to. So there is no need to set force_write in this scenario. > This commit reverts half

[PATCH 3/8] lock_ref_sha1_basic(): do not set force_write for missing references

2015-02-09 Thread Michael Haggerty
If a reference is missing, its SHA-1 will be null_sha1, which can't possibly match a new value that ref_transaction_commit() is trying to update it to. So there is no need to set force_write in this scenario. Signed-off-by: Michael Haggerty --- refs.c | 15 ++- 1 file changed, 6 inse