Re: [PATCH 3/8] tag: Change misleading --list documentation

2017-03-20 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > >> I think it's expected to work under the usual last-one-wins option >> parsing. A more subtle case is that: >> >> git tag -l -d foo >> >> would override "-l" with "-d". That's reasonable under the same rule as >> long as the user knows that the tw

Re: [PATCH 3/8] tag: Change misleading --list documentation

2017-03-20 Thread Ævar Arnfjörð Bjarmason
On Mon, Mar 20, 2017 at 4:44 AM, Jeff King wrote: > On Sat, Mar 18, 2017 at 11:43:47AM -0700, Junio C Hamano wrote: > >> > +test_expect_success 'Multiple -l or --list options are equivalent to one >> > -l option' ' >> > + git tag -l -l >actual && >> > + test_cmp expect actual && >> > + git

Re: [PATCH 3/8] tag: Change misleading --list documentation

2017-03-20 Thread Jeff King
On Mon, Mar 20, 2017 at 05:09:02PM +0100, Ævar Arnfjörð Bjarmason wrote: > > I think it's expected to work under the usual last-one-wins option > > parsing. A more subtle case is that: > > > > git tag -l -d foo > > > > would override "-l" with "-d". That's reasonable under the same rule as > > l

Re: [PATCH 3/8] tag: Change misleading --list documentation

2017-03-20 Thread Junio C Hamano
Jeff King writes: > I think it's expected to work under the usual last-one-wins option > parsing. A more subtle case is that: > > git tag -l -d foo > > would override "-l" with "-d". That's reasonable under the same rule as > long as the user knows that the two are mode-selectors. I don't think

Re: [PATCH 3/8] tag: Change misleading --list documentation

2017-03-19 Thread Jeff King
On Sat, Mar 18, 2017 at 11:43:47AM -0700, Junio C Hamano wrote: > > +test_expect_success 'Multiple -l or --list options are equivalent to one > > -l option' ' > > + git tag -l -l >actual && > > + test_cmp expect actual && > > + git tag --list --list >actual && > > + test_cmp expect actual

Re: [PATCH 3/8] tag: Change misleading --list documentation

2017-03-18 Thread Ævar Arnfjörð Bjarmason
On Sat, Mar 18, 2017 at 7:43 PM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> However, documenting this as "-l " was never correct, as >> these both worked before Jeff's change: >> >> git tag -l 'v*' >> git tag 'v*' -l > > Actually, we do not particularly care about the l

Re: [PATCH 3/8] tag: Change misleading --list documentation

2017-03-18 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > However, documenting this as "-l " was never correct, as > these both worked before Jeff's change: > > git tag -l 'v*' > git tag 'v*' -l Actually, we do not particularly care about the latter, and quite honestly, I'd prefer we do not advertise and encou

[PATCH 3/8] tag: Change misleading --list documentation

2017-03-18 Thread Ævar Arnfjörð Bjarmason
Change the documentation for --list so that it's described as a toggle, not as an option that takes a as an argument. Junio initially documented this in b867c7c23a ("git-tag: -l to list tags (usability).", 2006-02-17), but later Jeff King changed "tag" to accept multiple patterns in 588d0e834b ("