Re: [PATCH 4/3] http: check curl_multi_remove_handle error code

2016-09-21 Thread Jeff King
On Wed, Sep 21, 2016 at 10:29:59PM +, Eric Wong wrote: > Jeff King wrote: > > On Wed, Sep 21, 2016 at 09:46:23PM +, Eric Wong wrote: > > > > > ---8<--- > > > Subject: [PATCH] http: check curl_multi_remove_handle error code > > > > > > This should help

Re: [PATCH 4/3] http: check curl_multi_remove_handle error code

2016-09-21 Thread Eric Wong
Jeff King wrote: > On Wed, Sep 21, 2016 at 09:46:23PM +, Eric Wong wrote: > > > ---8<--- > > Subject: [PATCH] http: check curl_multi_remove_handle error code > > > > This should help detect bugs in future changes. While we're at > > it, fix a (probably

Re: [PATCH 4/3] http: check curl_multi_remove_handle error code

2016-09-21 Thread Jeff King
On Wed, Sep 21, 2016 at 09:46:23PM +, Eric Wong wrote: > ---8<--- > Subject: [PATCH] http: check curl_multi_remove_handle error code > > This should help detect bugs in future changes. While we're at > it, fix a (probably innocuous) bug in our http_cleanup function > for

[PATCH 4/3] http: check curl_multi_remove_handle error code

2016-09-21 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > The key patch here is 3/3 which seems like an obvious fix to > > adding the problem of adding a curl easy handle to a curl multi > > handle repeatedly. > > Yeah, sounds like the right thing to do and 2/3 makes it