On Mon, Jun 13, 2016 at 06:31:29PM +0700, Duy Nguyen wrote:
> > This is a fairly mechanical conversion; I assumed each site
> > was correct as-is, and just switched them all to NODUP.
>
> Looking good. If we still want to reduce noise level down (by a tiny
> bit), we could remove _INIT because I
On Mon, Jun 13, 2016 at 5:04 PM, Jeff King wrote:
> -- >8 --
> Subject: use string_list initializer consistently
>
> There are two types of string_lists: those that own the
> string memory, and those that don't. You can tell the
> difference by the strdup_strings flag, and one should use
> either
On Mon, Jun 13, 2016 at 04:36:14PM +0700, Duy Nguyen wrote:
> > So I'd suggest these patches:
> >
> > [1/3]: parse_opt_string_list: stop allocating new strings
> > [2/3]: interpret-trailers: don't duplicate option strings
> > [3/3]: blame,shortlog: don't make local option variables static
>
3 matches
Mail list logo