Re: [PATCH 4/4] Move documentation of string_list into string-list.h

2017-09-27 Thread Andrey Rybak
On 25.09.2017 20:40, Brandon Williams wrote: > On 09/25, Han-Wen Nienhuys wrote: >> This mirrors commit bdfdaa4978dd92992737e662f25adc01d32d0774 which did > > Not really important but most times we reference another commit from a > commit msg we include the one line summary like: > 'bdfdaa497

Re: [PATCH 4/4] Move documentation of string_list into string-list.h

2017-09-26 Thread Han-Wen Nienhuys
On Tue, Sep 26, 2017 at 7:22 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> >> Thanks. I am not sure if you can safely reorder the contents of the >> header files in general, but I trust that you made sure that this >> does not introduce problems (e.g. referrals before definition). > >

Re: [PATCH 4/4] Move documentation of string_list into string-list.h

2017-09-25 Thread Junio C Hamano
Junio C Hamano writes: > > Thanks. I am not sure if you can safely reorder the contents of the > header files in general, but I trust that you made sure that this > does not introduce problems (e.g. referrals before definition). Alas, this time it seems my trust was grossly misplaced. Discardi

Re: [PATCH 4/4] Move documentation of string_list into string-list.h

2017-09-25 Thread Junio C Hamano
Han-Wen Nienhuys writes: > This mirrors commit bdfdaa4978dd92992737e662f25adc01d32d0774 which did > the same for strbuf.h: > > * API documentation uses /** */ to set it apart from other comments. > > * Function names were stripped from the comments. > > * Ordering of the header was adjusted to fo

Re: [PATCH 4/4] Move documentation of string_list into string-list.h

2017-09-25 Thread Stefan Beller
On Mon, Sep 25, 2017 at 10:40 AM, Brandon Williams wrote: > On 09/25, Han-Wen Nienhuys wrote: >> This mirrors commit bdfdaa4978dd92992737e662f25adc01d32d0774 which did > > Not really important but most times we reference another commit from a > commit msg we include the one line summary like: >

Re: [PATCH 4/4] Move documentation of string_list into string-list.h

2017-09-25 Thread Brandon Williams
On 09/25, Han-Wen Nienhuys wrote: > This mirrors commit bdfdaa4978dd92992737e662f25adc01d32d0774 which did Not really important but most times we reference another commit from a commit msg we include the one line summary like: 'bdfdaa497 (strbuf.h: integrate api-strbuf.txt documentation, 2

[PATCH 4/4] Move documentation of string_list into string-list.h

2017-09-25 Thread Han-Wen Nienhuys
This mirrors commit bdfdaa4978dd92992737e662f25adc01d32d0774 which did the same for strbuf.h: * API documentation uses /** */ to set it apart from other comments. * Function names were stripped from the comments. * Ordering of the header was adjusted to follow the one from the text file. * Ed