Re: [PATCH 4/5] commit-graph: store graph in struct object_store

2018-06-26 Thread Junio C Hamano
Jonathan Tan writes: > As for whether both these functions are necessary in the first place, I > think they are. I do not mind their existence. I was wondering if they can share more implementation; such a design would need s/the_commit_graph/the_repo->objstore->commit_graph/ only once as a

Re: [PATCH 4/5] commit-graph: store graph in struct object_store

2018-06-25 Thread Jonathan Tan
> I was looking at semantic merge conflicts between this and your > e2838d85 ("commit-graph: always load commit-graph information", > 2018-05-01), the latter of which I planned to merge to 'master' as a > part of the first batch in this cycle, and noticed that there are > two very similar

Re: [PATCH 4/5] commit-graph: store graph in struct object_store

2018-06-25 Thread Junio C Hamano
Jonathan Tan writes: > Instead of storing commit graphs in static variables, store them in > struct object_store. There are no changes to the signatures of existing > functions - they all still only support the_repository, and support for > other instances of struct repository will be added in a

[PATCH 4/5] commit-graph: store graph in struct object_store

2018-06-21 Thread Jonathan Tan
Instead of storing commit graphs in static variables, store them in struct object_store. There are no changes to the signatures of existing functions - they all still only support the_repository, and support for other instances of struct repository will be added in a subsequent commit.