Re: [PATCH 4/5] travis-ci: don't run the test suite as root in the 32 bit Linux build

2018-01-24 Thread Jeff King
On Wed, Jan 24, 2018 at 01:01:42PM -0500, Jeff King wrote: > Just for fun, I tried running: > > cd t > best-of-five make GIT_PROVE_OPTS='-j3' > best-of-five make GIT_PROVE_OPTS='-j3 --state=slow,save' > best-of-five make GIT_PROVE_OPTS='-j3 --shuffle' > [...] > I wonder what is different

Re: [PATCH 4/5] travis-ci: don't run the test suite as root in the 32 bit Linux build

2018-01-24 Thread Jeff King
On Wed, Jan 24, 2018 at 10:56:22AM -0500, Jeff King wrote: > > > (As an aside, I'm not sure the prove cache is doing much. Running in > > > slow-to-fast order helps if you are trying to run massively in parallel, > > > but we only use -j3 for our Travis builds). > > > > It saves about a minute /

Re: [PATCH 4/5] travis-ci: don't run the test suite as root in the 32 bit Linux build

2018-01-24 Thread Jeff King
On Wed, Jan 24, 2018 at 02:45:18PM +0100, SZEDER Gábor wrote: > I think the key is the handling of verbose logs of failed test(s). The > original motivation for matching the user IDs was, I suppose, that we > wanted to dump the verbose log of the failed test(s) to the trace log on > the host, bec

Re: [PATCH 4/5] travis-ci: don't run the test suite as root in the 32 bit Linux build

2018-01-24 Thread SZEDER Gábor
On Tue, Jan 23, 2018 at 5:43 PM, Jeff King wrote: > On Mon, Jan 22, 2018 at 02:32:19PM +0100, SZEDER Gábor wrote: > >> Travis CI runs the 32 bit Linux build job in a Docker container, where >> all commands are executed as root by default. Therefore, ever since >> we added this build job in 88dedd

Re: [PATCH 4/5] travis-ci: don't run the test suite as root in the 32 bit Linux build

2018-01-23 Thread Jeff King
On Mon, Jan 22, 2018 at 02:32:19PM +0100, SZEDER Gábor wrote: > Travis CI runs the 32 bit Linux build job in a Docker container, where > all commands are executed as root by default. Therefore, ever since > we added this build job in 88dedd5e7 (Travis: also test on 32-bit > Linux, 2017-03-05), we

[PATCH 4/5] travis-ci: don't run the test suite as root in the 32 bit Linux build

2018-01-22 Thread SZEDER Gábor
Travis CI runs the 32 bit Linux build job in a Docker container, where all commands are executed as root by default. Therefore, ever since we added this build job in 88dedd5e7 (Travis: also test on 32-bit Linux, 2017-03-05), we have a bit of code to create a user in the container matching the ID o