Re: [PATCH 4/6] config: return configset value for current_config_ functions

Jeff King writes: > I think the issue is that bin-wrappers serves two purposes. One is for > testing, but the other is for people who run git directly without > installing. Hmph. It may have been a useful way to "run without installing" once in the past, but with the "check and

Re: [PATCH 4/6] config: return configset value for current_config_ functions

On Thu, May 26, 2016 at 10:36:44AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > The problem is running test-config inside of a git alias. The > > bin-wrappers will set the exec-path to the root-level of git's build > > directory, which the git binary will then stick at

Re: [PATCH 4/6] config: return configset value for current_config_ functions

On Thu, May 26, 2016 at 12:50:33PM -0400, Jeff King wrote: > > Remind me why we end up running ./test-config instead of > > ./bin-wrappers/test-config? Should our tests be running > > bin-wrappers early in their $PATH, perhaps? > > The problem is running test-config inside of a git alias. The

Re: [PATCH 4/6] config: return configset value for current_config_ functions

Jeff King writes: > The problem is running test-config inside of a git alias. The > bin-wrappers will set the exec-path to the root-level of git's build > directory, which the git binary will then stick at the front of the > $PATH. I was wondering why exec-path does not point at

Re: [PATCH 4/6] config: return configset value for current_config_ functions

On Thu, May 26, 2016 at 09:42:48AM -0700, Junio C Hamano wrote: > Duy Nguyen writes: > > > On Thu, May 19, 2016 at 7:08 AM, Jeff King wrote: > >> On Wed, May 18, 2016 at 06:43:23PM -0400, Jeff King wrote: > >> > >>> cache.h| 1 + > >>>

Re: [PATCH 4/6] config: return configset value for current_config_ functions

Duy Nguyen writes: > On Thu, May 19, 2016 at 7:08 AM, Jeff King wrote: >> On Wed, May 18, 2016 at 06:43:23PM -0400, Jeff King wrote: >> >>> cache.h| 1 + >>> config.c | 51 >>> +-

Re: [PATCH 4/6] config: return configset value for current_config_ functions

On Thu, May 19, 2016 at 7:08 AM, Jeff King wrote: > On Wed, May 18, 2016 at 06:43:23PM -0400, Jeff King wrote: > >> cache.h| 1 + >> config.c | 51 >> +- >> t/helper/test-config.c | 20

Re: [PATCH 4/6] config: return configset value for current_config_ functions

On Wed, May 18, 2016 at 06:43:23PM -0400, Jeff King wrote: > cache.h| 1 + > config.c | 51 > +- > t/helper/test-config.c | 20 > t/t1308-config-set.sh | 23 +++ > [...] >

[PATCH 4/6] config: return configset value for current_config_ functions

When 473166b (config: add 'origin_type' to config_source struct, 2016-02-19) added accessor functions for the origin type and name, it taught them only to look at the "cf" struct that is filled in while we are parsing the config. This is sufficient to make it work with git-config, which uses