Re: [PATCH 4/6] fsck: tighten error-checks of "git fsck "

2017-01-17 Thread Junio C Hamano
Jeff King writes: > Instead of checking reachability from the refs, you can ask > fsck to check from a particular set of heads. However, the > error checking here is quite lax. In particular: > > 1. It claims lookup_object() will report an error, which > is not true. It

[PATCH 4/6] fsck: tighten error-checks of "git fsck "

2017-01-16 Thread Jeff King
Instead of checking reachability from the refs, you can ask fsck to check from a particular set of heads. However, the error checking here is quite lax. In particular: 1. It claims lookup_object() will report an error, which is not true. It only does a hash lookup, and the user has no