Re: [PATCH 4/7] trace: cosmetic fixes for error messages

2016-08-05 Thread Jeff King
On Thu, Aug 04, 2016 at 01:42:12PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > I think it would be nicer to still to print: > > > > warning: first line > > warning: second line > > > > etc. We do that for "advice:", but not the rest of the vreportf > > functions. It might be nice to

Re: [PATCH 4/7] trace: cosmetic fixes for error messages

2016-08-04 Thread Junio C Hamano
Jeff King writes: > I think it would be nicer to still to print: > > warning: first line > warning: second line > > etc. We do that for "advice:", but not the rest of the vreportf > functions. It might be nice to do that, but we'd have to go back to > printing into a buffer (since we can't brea

[PATCH 4/7] trace: cosmetic fixes for error messages

2016-08-03 Thread Jeff King
The error messages for the trace code are often multi-line; the first line gets a nice "warning:", but the rest are left-aligned. Let's give them an indentation to make sure they stand out as a unit. While we're here, let's also downcase the first letter of each error (our usual style), and break