Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Dan Carpenter
On Sat, Sep 13, 2014 at 11:57:51PM +0300, Dan Carpenter wrote: > On Sat, Sep 13, 2014 at 09:47:45PM +0100, Mark Einon wrote: > > On Sat, Sep 13, 2014 at 04:36:45PM -0400, Jeff King wrote: > > > I don't think we can make this 100% foolproof without knowing which mbox > > > variant the writer used. B

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Mark Einon
On Sat, Sep 13, 2014 at 11:57:51PM +0300, Dan Carpenter wrote: > On Sat, Sep 13, 2014 at 09:47:45PM +0100, Mark Einon wrote: > > On Sat, Sep 13, 2014 at 04:36:45PM -0400, Jeff King wrote: > > > I don't think we can make this 100% foolproof without knowing which mbox > > > variant the writer used. B

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Mark Einon
On Sat, Sep 13, 2014 at 04:36:45PM -0400, Jeff King wrote: > I don't think we can make this 100% foolproof without knowing which mbox > variant the writer used. But dropping the line is probably the worst > possible thing, as it does not match _any_ variants. :) Hi, FYI it was 'git send-email' v2

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Dan Carpenter
On Sat, Sep 13, 2014 at 09:47:45PM +0100, Mark Einon wrote: > On Sat, Sep 13, 2014 at 04:36:45PM -0400, Jeff King wrote: > > I don't think we can make this 100% foolproof without knowing which mbox > > variant the writer used. But dropping the line is probably the worst > > possible thing, as it do

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Jeff King
On Sat, Sep 13, 2014 at 08:45:56AM -0700, Greg KH wrote: > On Sat, Sep 13, 2014 at 12:37:46PM +0300, Dan Carpenter wrote: > > On Thu, Sep 11, 2014 at 10:59:42PM +0100, Mark Einon wrote: > > > >From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd, > > > multicast_pkts_xmtd, broadcast_pkts_rcv

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Dan Carpenter
On Sat, Sep 13, 2014 at 08:45:56AM -0700, Greg KH wrote: > On Sat, Sep 13, 2014 at 12:37:46PM +0300, Dan Carpenter wrote: > > On Thu, Sep 11, 2014 at 10:59:42PM +0100, Mark Einon wrote: > > > >From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd, > > > multicast_pkts_xmtd, broadcast_pkts_rcvd

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Greg KH
On Sat, Sep 13, 2014 at 12:37:46PM +0300, Dan Carpenter wrote: > On Thu, Sep 11, 2014 at 10:59:42PM +0100, Mark Einon wrote: > > >From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd, > > multicast_pkts_xmtd, broadcast_pkts_rcvd and broadcast_pkts_xmtd > > For some reason something adds a '>

Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

2014-09-13 Thread Dan Carpenter
On Thu, Sep 11, 2014 at 10:59:42PM +0100, Mark Einon wrote: > >From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd, > multicast_pkts_xmtd, broadcast_pkts_rcvd and broadcast_pkts_xmtd For some reason something adds a '>' to the start of lines which start with 'From'. I don't know what it is