Re: [PATCH 4/9] read_early_config(): optionally return the worktree's top-level directory

2017-06-08 Thread Brandon Williams
On 06/08, Johannes Schindelin wrote: > Hi Brandon, > > On Thu, 8 Jun 2017, Brandon Williams wrote: > > > On 06/08, Johannes Schindelin wrote: > > > > > > On Thu, 8 Jun 2017, Brandon Williams wrote: > > > > > > > On 06/08, Johannes Schindelin wrote: > > > > > > > > > Back to the worktree_dir

Re: [PATCH 4/9] read_early_config(): optionally return the worktree's top-level directory

2017-06-08 Thread Johannes Schindelin
Hi Brandon, On Thu, 8 Jun 2017, Brandon Williams wrote: > On 06/08, Johannes Schindelin wrote: > > > > On Thu, 8 Jun 2017, Brandon Williams wrote: > > > > > On 06/08, Johannes Schindelin wrote: > > > > > > > Back to the worktree_dir variable. > > > > > > > > I think part of the confusion

Re: [PATCH 4/9] read_early_config(): optionally return the worktree's top-level directory

2017-06-08 Thread Brandon Williams
On 06/08, Johannes Schindelin wrote: > Hi Brandon, > > On Thu, 8 Jun 2017, Brandon Williams wrote: > > > On 06/08, Johannes Schindelin wrote: > > > > > Back to the worktree_dir variable. > > > > > > I think part of the confusion here is that it may be left alone even > > > when there is a

Re: [PATCH 4/9] read_early_config(): optionally return the worktree's top-level directory

2017-06-08 Thread Johannes Schindelin
Hi Brandon, On Thu, 8 Jun 2017, Brandon Williams wrote: > On 06/08, Johannes Schindelin wrote: > > > Back to the worktree_dir variable. > > > > I think part of the confusion here is that it may be left alone even > > when there is a worktree. For example, if we are already in the > > top-level

Re: [PATCH 4/9] read_early_config(): optionally return the worktree's top-level directory

2017-06-08 Thread Brandon Williams
On 06/08, Johannes Schindelin wrote: > Hi Brandon, > > On Wed, 7 Jun 2017, Brandon Williams wrote: > > > On 06/07, Johannes Schindelin wrote: > > > @@ -1668,7 +1668,7 @@ void read_early_config(config_fn_t cb, void *data) > > >* notably, the current working directory is still the same after

Re: [PATCH 4/9] read_early_config(): optionally return the worktree's top-level directory

2017-06-08 Thread Johannes Schindelin
Hi Brandon, On Wed, 7 Jun 2017, Brandon Williams wrote: > On 06/07, Johannes Schindelin wrote: > > @@ -1668,7 +1668,7 @@ void read_early_config(config_fn_t cb, void *data) > > * notably, the current working directory is still the same after the > > * call). > > */ > > - else if

Re: [PATCH 4/9] read_early_config(): optionally return the worktree's top-level directory

2017-06-07 Thread Brandon Williams
On 06/07, Johannes Schindelin wrote: > So far, when we invoked the early config code path, we implicitly > determined the top-level directory of the worktree while discovering the > .git/ directory. > > And then we simply forgot that information. > > However, when we expand aliases, we very much

[PATCH 4/9] read_early_config(): optionally return the worktree's top-level directory

2017-06-07 Thread Johannes Schindelin
So far, when we invoked the early config code path, we implicitly determined the top-level directory of the worktree while discovering the .git/ directory. And then we simply forgot that information. However, when we expand aliases, we very much need that information, as aliases expanding to