Re: [PATCH 5/7] parse_color: support 24-bit RGB values

2014-11-20 Thread Junio C Hamano
Jeff King writes: > On Thu, Nov 20, 2014 at 11:44:26AM -0800, Junio C Hamano wrote: > >> > @@ -32,10 +32,13 @@ struct color { >> >COLOR_UNSPECIFIED = 0, >> >COLOR_NORMAL, >> >COLOR_ANSI, /* basic 0-7 ANSI colors */ >> > - COLOR_256 >> > + COLO

Re: [PATCH 5/7] parse_color: support 24-bit RGB values

2014-11-20 Thread Jeff King
On Thu, Nov 20, 2014 at 11:44:26AM -0800, Junio C Hamano wrote: > > @@ -32,10 +32,13 @@ struct color { > > COLOR_UNSPECIFIED = 0, > > COLOR_NORMAL, > > COLOR_ANSI, /* basic 0-7 ANSI colors */ > > - COLOR_256 > > + COLOR_256, > > + C

Re: [PATCH 5/7] parse_color: support 24-bit RGB values

2014-11-20 Thread Junio C Hamano
Jeff King writes: > Some terminals (like XTerm) allow full 24-bit RGB color > specifications using an extension to the regular ANSI color > scheme. Let's allow users to specify hex RGB colors, > enabling the all-important feature of hot pink ref > decorations: > > git log --format="%h%C(#ff69b4

[PATCH 5/7] parse_color: support 24-bit RGB values

2014-11-20 Thread Jeff King
Some terminals (like XTerm) allow full 24-bit RGB color specifications using an extension to the regular ANSI color scheme. Let's allow users to specify hex RGB colors, enabling the all-important feature of hot pink ref decorations: git log --format="%h%C(#ff69b4)%d%C(reset) %s" Signed-off-by: