Re: [PATCH 54/68] drop strcpy in favor of raw sha1_to_hex

On Thu, Sep 24, 2015 at 5:08 PM, Jeff King wrote: > In some cases where we strcpy() the result of sha1_to_hex(), > there's no need; the result goes directly into a printf > statement, and we can simply pass the return value from > sha1_to_hex() directly. > > When this code was

[PATCH 54/68] drop strcpy in favor of raw sha1_to_hex

In some cases where we strcpy() the result of sha1_to_hex(), there's no need; the result goes directly into a printf statement, and we can simply pass the return value from sha1_to_hex() directly. When this code was originally written, sha1_to_hex used a single buffer, and it was not safe to use

Re: [PATCH 54/68] drop strcpy in favor of raw sha1_to_hex

On Thu, Sep 24, 2015 at 07:42:05PM -0400, Eric Sunshine wrote: > On Thu, Sep 24, 2015 at 5:08 PM, Jeff King wrote: > > In some cases where we strcpy() the result of sha1_to_hex(), > > there's no need; the result goes directly into a printf > > statement, and we can simply pass the