Re: [PATCH 6/6] odb_pack_keep(): stop generating keepfile name

2017-03-15 Thread Junio C Hamano
Jeff King writes: > The odb_pack_keep() function generates the name of a .keep > file and opens it. This has two problems: > > 1. It requires a fixed-size buffer to create the filename > and doesn't notice when the result is truncated. > > 2. Of the two callers, one

[PATCH 6/6] odb_pack_keep(): stop generating keepfile name

2017-03-15 Thread Jeff King
The odb_pack_keep() function generates the name of a .keep file and opens it. This has two problems: 1. It requires a fixed-size buffer to create the filename and doesn't notice when the result is truncated. 2. Of the two callers, one sometimes wants to open a filename it already