Re: [PATCH 6/6] reflog-walk: stop using fake parents

2017-07-10 Thread Junio C Hamano
Eric Wong writes: > To notice similar errors sooner, I wonder if we should have a > test target for 64-bit users to test with -m32 enabled, somehow. Thanks. Hopefully https://travis-ci.org/git/git/jobs/251772744 and its later incarnations should be sufficient?

Re: [PATCH 6/6] reflog-walk: stop using fake parents

2017-07-10 Thread Jeff King
On Mon, Jul 10, 2017 at 09:42:55AM +, Eric Wong wrote: > > Thanks, I was able to reproduce with CFLAGS=-m32. > > No problem and thanks for the quick response! Latest pu is > fine for me. > > To notice similar errors sooner, I wonder if we should have a > test target for 64-bit users to

Re: [PATCH 6/6] reflog-walk: stop using fake parents

2017-07-10 Thread Eric Wong
Jeff King wrote: > On Fri, Jul 07, 2017 at 12:32:39AM +, Eric Wong wrote: > > > I'm not sure why, but this is causing t1414.8 failures on 32-bit > > x86 with the latest pu with Debian jessie (oldstable). > > > > Reverting this (beafb2c62947a6d4a97b9c3baf99fe62ec8e830f) in pu

Re: [PATCH 6/6] reflog-walk: stop using fake parents

2017-07-06 Thread Jeff King
On Thu, Jul 06, 2017 at 11:02:24PM -0400, Jeff King wrote: > On Fri, Jul 07, 2017 at 12:32:39AM +, Eric Wong wrote: > > > I'm not sure why, but this is causing t1414.8 failures on 32-bit > > x86 with the latest pu with Debian jessie (oldstable). > > > > Reverting this

Re: [PATCH 6/6] reflog-walk: stop using fake parents

2017-07-06 Thread Jeff King
On Fri, Jul 07, 2017 at 12:32:39AM +, Eric Wong wrote: > I'm not sure why, but this is causing t1414.8 failures on 32-bit > x86 with the latest pu with Debian jessie (oldstable). > > Reverting this (beafb2c62947a6d4a97b9c3baf99fe62ec8e830f) in pu > seems to fix the test for me. > > +Cc:

Re: [PATCH 6/6] reflog-walk: stop using fake parents

2017-07-06 Thread Eric Wong
I'm not sure why, but this is causing t1414.8 failures on 32-bit x86 with the latest pu with Debian jessie (oldstable). Reverting this (beafb2c62947a6d4a97b9c3baf99fe62ec8e830f) in pu seems to fix the test for me. +Cc: Ramsay since he also had a 32-bit environment. --8<-- ok 7 - --parents shows

[PATCH 6/6] reflog-walk: stop using fake parents

2017-07-05 Thread Jeff King
The reflog-walk system works by putting a ref's tip into the pending queue, and then "traversing" the reflog by pretending that the parent of each commit is the previous reflog entry. This causes a number of user-visible oddities, as documented in t1414 (and the commit message which introduced