Re: [PATCH 6/7] Switch path canonicalization to use the SVN API.

2012-08-02 Thread Michael G Schwern
On 2012.8.2 2:51 PM, Eric Wong wrote: svn_path_canonicalize() may be accessible in some versions of SVN, but it'll return undef. Yuck! Good catch! I've tested the following on an old CentOS 5.2 chroot with SVN 1.4.2: Looks good to me. -- Alligator sandwich, and make it snappy! -- To

Re: [PATCH 6/7] Switch path canonicalization to use the SVN API.

2012-07-30 Thread Eric Wong
Michael G Schwern schw...@pobox.com wrote: On 2012.7.28 6:55 AM, Jonathan Nieder wrote: Michael G. Schwern wrote: --- a/perl/Git/SVN/Utils.pm +++ b/perl/Git/SVN/Utils.pm @@ -86,6 +86,27 @@ sub _collapse_dotdot { sub canonicalize_path { + my $path = shift; + + # The 1.7

[PATCH 6/7] Switch path canonicalization to use the SVN API.

2012-07-28 Thread Michael G. Schwern
From: Michael G. Schwern schw...@pobox.com All tests pass with SVN 1.6. SVN 1.7 remains broken, not worrying about it yet. SVN changed its path canonicalization API between 1.6 and 1.7. http://svnbook.red-bean.com/en/1.6/svn.developer.usingapi.html#svn.developer.usingapi.urlpath

Re: [PATCH 6/7] Switch path canonicalization to use the SVN API.

2012-07-28 Thread Jonathan Nieder
Michael G. Schwern wrote: --- a/perl/Git/SVN/Utils.pm +++ b/perl/Git/SVN/Utils.pm @@ -86,6 +86,27 @@ sub _collapse_dotdot { sub canonicalize_path { + my $path = shift; + + # The 1.7 way to do it + if ( defined SVN::_Core::svn_dirent_canonicalize ) { + $path

Re: [PATCH 6/7] Switch path canonicalization to use the SVN API.

2012-07-28 Thread Michael G Schwern
On 2012.7.28 6:55 AM, Jonathan Nieder wrote: Michael G. Schwern wrote: --- a/perl/Git/SVN/Utils.pm +++ b/perl/Git/SVN/Utils.pm @@ -86,6 +86,27 @@ sub _collapse_dotdot { sub canonicalize_path { +my $path = shift; + +# The 1.7 way to do it +if ( defined