Re: [PATCH 6/8] grep: make it clear i-t-a entries are ignored

2015-08-25 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: The expression !S_ISREG(ce) covers i-t-a entries as well because ce-ce_mode would be zero then. I could make a comment saying that, but it's probably better just to comment with code, in case i-t-a entry content changes in future. OK. Thansk.

Re: [PATCH 6/8] grep: make it clear i-t-a entries are ignored

2015-08-25 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: The expression !S_ISREG(ce) covers i-t-a entries as well because ce-ce_mode would be zero then. I could make a comment saying that, but it's probably better just to comment with code, in case i-t-a entry content changes in future. OK. Thanks.

[PATCH 6/8] grep: make it clear i-t-a entries are ignored

2015-08-21 Thread Nguyễn Thái Ngọc Duy
The expression !S_ISREG(ce) covers i-t-a entries as well because ce-ce_mode would be zero then. I could make a comment saying that, but it's probably better just to comment with code, in case i-t-a entry content changes in future. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com ---